Skip to content

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Apr 30, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 30, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2022
@euclio
Copy link
Contributor

euclio commented May 1, 2022

Missing a toilet closure (|_| ())? ;)

@thomcc
Copy link
Member Author

thomcc commented May 1, 2022

Missing a toilet closure (|_| ())? ;)

I suppose I could do something like

matches!((|_|())(()), _|_|_|_|_|_ if (i+=1) != (i+=1));

but this might be getting too cute with it. OTOH maybe that's fine in this file.


FWIW this isn't based on a real issue1, although I have seen real (non-contrived) code that depends on the evaluation behavior that makes the bathroom_stall() work. Although that code was terrible. Anyway I won't be heartbroken if we don't want to take this.

Footnotes

  1. The truth is I had written this PR a jillion years ago and left it in a forgotten checkout of rust-lang/rust, and only remembered it recently.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 1, 2022

📌 Commit dff97d5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#94126 (Classify BinaryHeap & LinkedList unit tests as such)
 - rust-lang#96222 (Clarify docs for `from_raw_parts` on `Vec` and `String`)
 - rust-lang#96499 (Make it possible to write doctests for bootstrap)
 - rust-lang#96567 (Fix docs for u32 and i32 logs func)
 - rust-lang#96568 (std::fmt: Various fixes and improvements to documentation)
 - rust-lang#96571 (Add a bathroom stall to weird expressions test)
 - rust-lang#96610 (Update browser-ui-test version to 0.9.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f6a89ee into rust-lang:master May 2, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants